Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We had problems on windows 32bit systems using the reparenting feature. #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JScheiterbauer
Copy link

Sometimes (timing issue) the JCEF native code in CefBrowser_N.cpp uses a wrong parent window handle. With this change the problem was gone, also see #321.

Reproduction:
The problem can happen on physical machines too but happen much more often when connected to remote machines (e.g. Citrix sessions, Remote Desktop, VMWares,...).

  • Start detailed MainFrame
  • Menu -> Tests -> Reparent
  • Press the "Reparent </>" Button as fast as you can (Space bar helps) The bug then sometimes happens on the 5th try or you have to do this for a minute or so.

Sometimes (timing issue) the JCEF native code in CefBrowser_N.cpp uses a wrong parent window handle.
With this change the problem was gone, also see chromiumembedded#321.

Reproduction:
The problem can happen on physical machines too but happen much more often when connected to remote machines (e.g. Citrix sessions, Remote Desktop, VMWares,...).
- Start detailed MainFrame
- Menu -> Tests -> Reparent
- Press the "Reparent </>" Button as fast as you can (Space bar helps)
The bug then sometimes happens on the 5th try or you have to do this for a minute or so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant